Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pull-requests.json to skip CI in some cases #469

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

rowlandgeoff
Copy link
Contributor

Skip CI when only unrelated changes are made.

Closes: #457

@rowlandgeoff rowlandgeoff requested a review from a team as a code owner October 4, 2024 19:18
@rowlandgeoff rowlandgeoff requested a review from v1v October 4, 2024 19:18
@rowlandgeoff rowlandgeoff self-assigned this Oct 4, 2024
Copy link

mergify bot commented Oct 4, 2024

This pull request does not have a backport label. Could you fix it @rowlandgeoff? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d is the label to automatically backport to the 1./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip label Oct 4, 2024
@rowlandgeoff rowlandgeoff added backport-v1.22 Automated label to backport with Mergify and removed backport-skip labels Oct 4, 2024
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with the required GH checks?

image

@rowlandgeoff
Copy link
Contributor Author

rowlandgeoff commented Oct 10, 2024

Will this work with the required GH checks?

@v1v Good question. I branched off of this branch and opened a test PR to see if it would trigger this new flow, but it didn't. I think the pull-requests.json change must need to be merged before it can go into effect. Once this is merged, I can open a test PR soon after to verify it works.

Based on the current branch protection rules, I think I'll need to change the check source from Buildkite to any source. That's what I've seen needed in the elastic-agent repo.
image

Also, those other two required Buildkite checks can probably be removed, since they're sub-jobs of the main pipeline.

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's see how the required checks do after merging it

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rowlandgeoff

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rowlandgeoff

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @rowlandgeoff

@rowlandgeoff rowlandgeoff merged commit 3d86832 into main Oct 10, 2024
10 checks passed
@rowlandgeoff rowlandgeoff deleted the skipCIconditions branch October 10, 2024 18:15
mergify bot pushed a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v1.22 Automated label to backport with Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[golang-crossbuild] Can CI skip running when non-code related changes?
4 participants