-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap few colors for EuiLoadingSpinner
and EuiLoadingChart
#8276
Merged
mgadewoll
merged 12 commits into
elastic:eui-theme/borealis
from
ek-so:ekso-loading-chart-remap
Jan 17, 2025
Merged
Remap few colors for EuiLoadingSpinner
and EuiLoadingChart
#8276
mgadewoll
merged 12 commits into
elastic:eui-theme/borealis
from
ek-so:ekso-loading-chart-remap
Jan 17, 2025
+25
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgadewoll
force-pushed
the
ekso-loading-chart-remap
branch
from
January 15, 2025 10:55
cf3bc4f
to
d6ee13a
Compare
mgadewoll
reviewed
Jan 15, 2025
Preview staging links for this PR:
|
💚 Build Succeeded
History
cc @mgadewoll |
mgadewoll
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🐈⬛ Great work on the updates! Thanks a lot for contributing! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
EuiLoadingChart
in mono version in dark mode:EuiLoadingSpinner
to unilize Borealis tokens instead of old Amsterdam tokens.QA
Remove or strikethrough items that do not apply to your PR.
General checklist
@default
if default values are missing) and playground toggles