Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remap few colors for EuiLoadingSpinner and EuiLoadingChart #8276

Merged
merged 12 commits into from
Jan 17, 2025

Conversation

ek-so
Copy link
Contributor

@ek-so ek-so commented Jan 15, 2025

Summary

This PR:

  • Changes grey shades used for the EuiLoadingChart in mono version in dark mode:
    CleanShot 2025-01-15 at 09 22 38@2x
  • Maps EuiLoadingSpinner to unilize Borealis tokens instead of old Amsterdam tokens.
    CleanShot 2025-01-15 at 09 23 07@2x

QA

Remove or strikethrough items that do not apply to your PR.

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately.
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@ek-so ek-so marked this pull request as ready for review January 15, 2025 10:22
@ek-so ek-so requested a review from a team as a code owner January 15, 2025 10:22
@mgadewoll mgadewoll force-pushed the ekso-loading-chart-remap branch from cf3bc4f to d6ee13a Compare January 15, 2025 10:55
@mgadewoll mgadewoll self-assigned this Jan 15, 2025
@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mgadewoll

Copy link
Contributor

@mgadewoll mgadewoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🐈‍⬛ Great work on the updates! Thanks a lot for contributing! 🎉

@mgadewoll mgadewoll merged commit ef28aee into elastic:eui-theme/borealis Jan 17, 2025
4 checks passed
@ek-so ek-so deleted the ekso-loading-chart-remap branch January 17, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants