Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta badge inner visual alignment #8255

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

ek-so
Copy link
Contributor

@ek-so ek-so commented Dec 30, 2024

Summary

  • Current EuiBetaBadge looks slightly unbalanced in terms of text baseline: the label with uppercase letters by nature feels like being shifted a bit more towards the top of the badge, so I pulled it down very slightly.
  • It also looks a bit too harsh when the text inside is bold, so I tried what if we make it semibold, and increase the font-size for smaller badge at the same time for better readability. This also makes the text better visually balanced with icon-only badge in terms of the line thickness.
    Badge

@kibanamachine
Copy link

Preview staging links for this PR:

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@ek-so ek-so marked this pull request as ready for review December 30, 2024 18:00
@ek-so ek-so requested a review from a team as a code owner December 30, 2024 18:00
@ek-so
Copy link
Contributor Author

ek-so commented Dec 30, 2024

Hey team, before reviewing from a technical side I'd like to ask somebody from design side to check the visual part and my considerations. @MichaelMarcialis @ryankeairns what are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants