Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update connecting.asciidoc #27

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Update connecting.asciidoc #27

merged 1 commit into from
Sep 29, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 22, 2022

Relates to elastic/docs#2518

In particular, this PR is related to the following link issues:

10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/8.0/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html
10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/8.1/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html
10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/8.2/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html
10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/8.3/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html
10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/8.4/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html
10:11:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/enterprise-search-clients/php/current/connecting.html contains broken links to:
10:11:43 INFO:build_docs:   - en/kibana/master/api-keys.html

@chriscressman
Copy link
Contributor

@ezimuel Are you OK with me merging this PR and backporting the commit to other branches?

To avoid issues when master changes to main, I need to backport this commit to the following branches:

  • 8.4
  • 8.3
  • 8.2
  • 8.1
  • 8.0
  • 7.17
  • 7.16

If it's OK with you, I'll merge this PR and then cherry-pick the commit to each of these branches.

@chriscressman chriscressman merged commit 90585a9 into elastic:master Sep 29, 2022
@chriscressman
Copy link
Contributor

I completed the backports. The change applied to 8.x only, so I cherry-pick the commit to 8.0 through 8.5.

@ezimuel
Copy link
Contributor

ezimuel commented Oct 11, 2022

Thanks @chriscressman. In the meantime I renamed master to main for enterprise-search-php.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants