Add missing parameter to xpack.info rest-api-spec #118954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added
>bug
:Core/Infra/REST API
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Hi @pquentin, I've created a changelog YAML for you. |
Pinging @elastic/es-security regarding |
mosche
approved these changes
Jan 8, 2025
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jan 8, 2025
* Add missing parameter to xpack.info rest-api-spec * Update docs/changelog/118954.yaml
pquentin
added a commit
to pquentin/elasticsearch
that referenced
this pull request
Jan 8, 2025
* Add missing parameter to xpack.info rest-api-spec * Update docs/changelog/118954.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 8, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 8, 2025
sarog
pushed a commit
to sarog/elasticsearch
that referenced
this pull request
Jan 22, 2025
…lastic#119739) * Add missing parameter to xpack.info rest-api-spec * Update docs/changelog/118954.yaml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when reviewing elastic/elasticsearch-specification#3297. The parameter is read here:
elasticsearch/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/rest/action/RestXPackInfoAction.java
Lines 47 to 48 in 8793248
By the way, should
accept_enterprisebe removed in 9.0, as stated in this comment?