Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] Add features to the highlights #118857

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[8.17] Add features to the highlights #118857

merged 3 commits into from
Dec 17, 2024
+25 −0

Conversation

wajihaparvez
Copy link
Contributor

Updating the highlights page with three new features.

Closes 592

@wajihaparvez wajihaparvez added >docs General docs changes Team:Docs Meta label for docs team v8.17.0 v8.17.1 labels Dec 17, 2024
@wajihaparvez wajihaparvez self-assigned this Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Dec 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Documentation preview:

@wajihaparvez wajihaparvez removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Dec 17, 2024
leemthompo
leemthompo approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with couple suggestions

docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved
docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved
@leemthompo leemthompo added auto-backport Automatically create backport pull requests when merged v8.18.0 labels Dec 17, 2024
leemthompo
leemthompo reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix heading levels

docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved
docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved
docs/reference/release-notes/highlights.asciidoc Outdated Show resolved Hide resolved
@leemthompo leemthompo enabled auto-merge (squash) December 17, 2024 16:42
@leemthompo leemthompo merged commit 1cda67a into elastic:8.17 Dec 17, 2024
4 of 5 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 118857

@wajihaparvez wajihaparvez deleted the 817-add-ml-release-highlights branch December 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemthompo leemthompo leemthompo approved these changes

Assignees

@wajihaparvez wajihaparvez

Labels
auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes Team:Docs Meta label for docs team v8.17.0 v8.17.1 v8.18.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wajihaparvez @elasticsearchmachine @leemthompo