Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searchable snapshot upgrade compatibility #118770

Merged
merged 18 commits into from
Jan 7, 2025
Merged

Searchable snapshot upgrade compatibility #118770

merged 18 commits into from
Jan 7, 2025

Conversation

drempapis
Copy link
Contributor

@drempapis drempapis commented Dec 16, 2024 •
edited by jira bot
Loading

This is similar to #118599, testing searchable snapshots for old-repo-versions

Closes ES-10243

@drempapis
Copy link
Contributor Author

drempapis commented Dec 17, 2024 •
edited
Loading

I have replicated the structure of #118599 for CI coverage. The new add-on here is the searchable snapshot package, which verifies searchable snapshots and uses a mount operation applied in cluster version Current-1 before an upgrade occurs.

@drempapis drempapis requested a review from javanna December 17, 2024 09:54
@drempapis drempapis marked this pull request as ready for review December 17, 2024 09:56
@drempapis drempapis self-assigned this Dec 17, 2024
@drempapis drempapis added >test Issues or PRs that are addressing/adding tests Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch :Search Foundations/Search Catch all for Search Foundations labels Dec 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

javanna
javanna reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I will have another look once you merged the PR that this depends on and updated this one accordingly. Thanks!

@drempapis drempapis mentioned this pull request Dec 17, 2024
Merged
@drempapis
Copy link
Contributor Author

Thank you, @javanna, for reviewing.

javanna
javanna approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drempapis drempapis merged commit 56becc5 into elastic:main Jan 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees

@drempapis drempapis

Labels
:Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drempapis @elasticsearchmachine @javanna