-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Small doc fix for updates related to _source defaults #118605
Merged
john-wagster
merged 1 commit into
elastic:main
from
john-wagster:doc_update_source_defaults
Dec 12, 2024
Merged
[DOC] Small doc fix for updates related to _source defaults #118605
john-wagster
merged 1 commit into
elastic:main
from
john-wagster:doc_update_source_defaults
Dec 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-wagster
added
>docs
General docs changes
auto-backport
Automatically create backport pull requests when merged
:Search Relevance/Search
Catch all for Search Relevance
v9.0.0
v8.17.1
v8.18.0
v7.17.27
labels
Dec 12, 2024
Documentation preview: |
elasticsearchmachine
added
Team:Docs
Meta label for docs team
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
labels
Dec 12, 2024
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
shainaraskas
approved these changes
Dec 12, 2024
john-wagster
added a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 12, 2024
john-wagster
added a commit
to john-wagster/elasticsearch
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Dec 12, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
maxhniebergall
pushed a commit
to maxhniebergall/elasticsearch
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
>docs
General docs changes
:Search Relevance/Search
Catch all for Search Relevance
Team:Docs
Meta label for docs team
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
v7.17.27
v8.17.1
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community member found an error in the docs related to the update api and the default for
_source
:https://elasticstack.slack.com/archives/C018C7B9T5F/p1734000667617069
Quickly validated with this query:
with
_source=true
or_source=text
in the query params I get:without
_source
in the query params I get:This is the correct behavior we want. So I just inverted the language in the docs.