Add option to store sparse_vector outside _source
#117917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces an option for `sparse_vector` to store its values separately from `_source` by using term vectors. This capability is primarly needed by the semantic text field.
jimczi
added
>feature
:Search Foundations/Mapping
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Search Foundations
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
|
Hi @jimczi, I've created a changelog YAML for you. |
kderusso
approved these changes
Dec 3, 2024
server/src/main/java/org/elasticsearch/index/mapper/vectors/XFeatureField.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackFeatures.java
Outdated
Show resolved
Hide resolved
benwtrent
approved these changes
Dec 3, 2024
server/src/test/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapperTests.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
mayya-sharipova
approved these changes
Dec 3, 2024
|
Not related to your PR, but I've noticed I am getting an error message during index metadata validation when trying to create an index with sparse_vector field: " Failed to parse mapping: The [sparse_vector] field type is not supported on indices created on versions 8.0 to 8.10." |
In which context? Are you testing with any of these versions? |
Mikep86
approved these changes
Dec 3, 2024
server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java
Outdated
Show resolved
Hide resolved
Mikep86
added
the
auto-backport
Mikep86
reviewed
Dec 4, 2024
server/src/main/java/org/elasticsearch/index/mapper/vectors/SparseVectorFieldMapper.java
Outdated
Show resolved
Hide resolved
💔 Backport failed
You can use sqren/backport to manually backport by running |
jimczi
removed
the
auto-backport
jimczi
added a commit
to jimczi/elasticsearch
that referenced
this pull request
Dec 4, 2024
This PR introduces an option for `sparse_vector` to store its values separately from `_source` by using term vectors. This capability is primarly needed by the semantic text field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an option for
sparse_vectorto store its values separately from_sourceby using term vectors.This capability is primarily needed by the semantic text field.