-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Semantic Search Tutorial to Use Elasticsearch Service and Remove References to Deprecated ELSER Service #117826
Conversation
Added a deprecation warning to the “Tutorial: semantic search with semantic_text” to inform users that the elser service is deprecated as of version 8.16 and will be removed in a future release. The warning advises users to use the Elasticsearch inference service with model_id in service_settings instead. This update aligns the tutorial with the existing deprecation notice on the ELSER documentation page, ensuring clarity for users following the tutorial.
Documentation preview: |
Issue raised here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that rather than using a deprecation warning here, we should just change this tutorial to use the elasticsearch service. There is an example of this here: https://www.elastic.co/guide/en/elasticsearch/reference/current/infer-service-elasticsearch.html#inference-example-elasticsearch-elser
Thank you for the feedback! I’ve updated the tutorial to use the Elasticsearch service as suggested and removed the deprecation warning. Please let me know if there’s anything else you’d like adjusted. |
Pinging @elastic/ml-core (Team:ML) |
Pinging @elastic/es-docs (Team:Docs) |
@elasticmachine run elasticsearch-ci/docs |
run docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for iterating!
We will also need to add PRs to add this change to other other branches: main, 8.17, 8.x. |
💔 Backport failed
You can use sqren/backport to manually backport by running |
@maxhniebergall according to this PR's labels, it should not have a changelog YAML, but I can't delete it because it is closed. Please either delete the changelog from the appropriate branch yourself, or adjust the labels. |
Added a deprecation warning to the “Tutorial: semantic search with semantic_text” to inform users that the elser service is deprecated as of version 8.16 and will be removed in a future release. The warning advises users to use the Elasticsearch inference service with model_id in service_settings instead. This update aligns the tutorial with the existing deprecation notice on the ELSER documentation page, ensuring clarity for users following the tutorial.
[x] Have you signed the contributor license agreement?
[x] Have you followed the contributor guidelines?
[N/A] If submitting code, have you built your formula locally prior to submission with
gradle check
?[N/A] If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
[N/A] If submitting code, have you checked that your submission is for an OS and architecture that we support?
[N/A] If you are submitting this code for a class then read our policy for that.