Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin/apm-data] Allow fallback of templates to template-resources #112614

Closed
wants to merge 2 commits into from

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Sep 6, 2024

The PR:

  • Refactors YamlTemplateRegistry to fallback to find resources in TemplateResources if the module doesn't have the resources. It also introduces a convention to use the package name as the folder name in the TemplateResource to keep interfaces a bit simple.
  • Moves the fallback lifecycle files for apm-data plugin to TemplateResources so that they can be overridden for serverless.

Related to: elastic/apm-server#13898

@lahsivjar
Copy link
Contributor Author

Finished by #112759

@lahsivjar lahsivjar closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant