Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin/apm-data] Use component-templates to configure fallback to ILM #112432

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

lahsivjar
Copy link
Contributor

@lahsivjar lahsivjar commented Sep 2, 2024

Moves fallback for ILM to component templates which will allow users to override DSL configurations as required even for versions > 8.15.0

PR is tested: elastic/apm-server#13898 (comment)

@lahsivjar lahsivjar requested a review from axw September 2, 2024 12:06
@lahsivjar lahsivjar requested a review from a team as a code owner September 2, 2024 12:06
@elasticsearchmachine elasticsearchmachine added v8.15.2 needs:triage Requires assignment of a team area label labels Sep 2, 2024
@lahsivjar lahsivjar added v8.15.1 >bug :Data Management/Data streams Data streams and their lifecycles and removed v8.15.2 labels Sep 2, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Sep 2, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@axw axw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. When we come to addressing the issue on main, we should add a YAML REST test that ensures we don't regress.

@lahsivjar lahsivjar merged commit 253e854 into elastic:8.15 Sep 2, 2024
15 checks passed
@lahsivjar lahsivjar deleted the fix-ilmdlm-take2 branch September 2, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team v8.15.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants