Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PUT /_connector path in connector.put #110874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ezimuel
Copy link
Contributor

@ezimuel ezimuel commented Jul 15, 2024

This PR fixes the connector.put rest-api-spec removing the PUT /_connector path.

I tested and it seems not possible to send PUT /_connector without the connector_id parameter.
See elastic/elasticsearch-specification#2715 for more details.

@elasticsearchmachine
Copy link
Collaborator

@ezimuel please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team v8.16.0 labels Jul 15, 2024
@kingherc kingherc added :EnterpriseSearch/Application Enterprise Search Team:Enterprise Search Meta label for Enterprise Search team labels Jul 16, 2024
@elasticsearchmachine elasticsearchmachine removed the needs:triage Requires assignment of a team area label label Jul 16, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ent-search-eng (Team:Enterprise Search)

@jedrazb jedrazb self-assigned this Jul 18, 2024
@ezimuel
Copy link
Contributor Author

ezimuel commented Aug 23, 2024

@jedrazb any news about this PR? Thanks.

@jedrazb
Copy link
Member

jedrazb commented Sep 3, 2024

Hey @ezimuel sorry I was on PTO and missed the ping.

I realised that in 8.14 the logic around POST _connector and PUT _connector was unified, and therefore the connector_id path param is optional for both requests. I verified on 8.15 in cloud:

I think we can close the PR?

Screenshot 2024-09-03 at 14 45 20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:EnterpriseSearch/Application Enterprise Search external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Enterprise Search Meta label for Enterprise Search team v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants