ESQL: Fix mixed cluster tests #107680
Merged
ESQL: Fix mixed cluster tests #107680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not send version as it was not an allowed parameter back then.
alex-spies
added
>test
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
alex-spies
commented
Apr 22, 2024
Comment on lines
1439
to
1444
| String versionString = null; | ||
| Set<EsqlVersion> versions = EsqlSpecTestCase.availableVersions(); | ||
| if (versions.isEmpty() == false) { | ||
| // Use the latest released version or SNAPSHOT, if available. | ||
| versionString = versions.stream().max(Comparator.comparingInt(EsqlVersion::id)).toString(); | ||
| } |
There was a problem hiding this comment.
We were sending a version in the JSON body on bwc tests; the version parameter is only available on 8.13.3+, though.
There was a problem hiding this comment.
C.f. corresponding entry in build.gradle:
elasticsearch/x-pack/plugin/esql/qa/server/mixed-cluster/build.gradle
Lines 33 to 36 in f7349e2
alex-spies
commented
Apr 22, 2024
| @@ -1552,7 +1552,7 @@ s2point1:d | s_mv:i | languages:i | |||
| 2.1 | 3 | null | |||
| ; | |||
|
|
|||
| evalOverridingKey | |||
| evalOverridingKey#[skip:-8.13.1,reason:fixed in 8.13.2] | |||
There was a problem hiding this comment.
Added in #107131, which was backported to 8.13.2 but not earlier.
alex-spies
added a commit
to alex-spies/elasticsearch
that referenced
this pull request
Apr 22, 2024
* Fix a test where pre-8.13 nodes in mixed cluster tests were sent a language version (added in 8.13.3). * Skip a test for a fix introduced in 8.13.2 on older clusters.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #107618.