Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Add version to docs #107225

Merged
merged 6 commits into from
Apr 15, 2024
Merged

Conversation

alex-spies
Copy link
Contributor

@alex-spies alex-spies commented Apr 8, 2024

Docs for #106824.

Does not cover the REST API specs as these don't cover the request body.

Copy link
Contributor

github-actions bot commented Apr 8, 2024

Documentation preview:

@alex-spies alex-spies marked this pull request as ready for review April 11, 2024 14:55
@alex-spies alex-spies added >docs General docs changes :Analytics/ES|QL AKA ESQL labels Apr 11, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Apr 11, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little copyediting from me :)

docs/reference/esql/esql-version.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/esql-version.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/esql-version.asciidoc Outdated Show resolved Hide resolved
docs/reference/esql/esql-version.asciidoc Outdated Show resolved Hide resolved
Their goal is to make sure that queries that were once written
remain valid even as Elasticsearch and {esql} evolve.

For instance, the following query
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't read well to have a code sample mid-sentence, so I'd recommend moving lines 41 + 42 up here.

docs/reference/esql/esql-version.asciidoc Outdated Show resolved Hide resolved
@nik9000 nik9000 added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Apr 15, 2024
@elasticsearchmachine elasticsearchmachine merged commit 71b276d into elastic:main Apr 15, 2024
5 checks passed
@alex-spies alex-spies deleted the esql-version-docs branch April 15, 2024 14:50
@alex-spies
Copy link
Contributor Author

Thanks for your help @nik9000 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v8.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants