[ML] Move byte embedding results to return results in text_embedding_bytes field #105290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
>non-issue
:ml
|
Pinging @elastic/ml-core (Team:ML) |
This was referenced Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR came about because the the clients code is unable to deduce the correct response type in the current implementation of
TextEmbeddingResultsandTextEmbeddingByteResultsbeing written to the same fieldtext_embedding. After chatting with the clients team they suggested we have the byte results be written to a new fieldtext_embedding_bytesto mitigate this.This is a breaking change for cohere but hopefully not many people are using it yet since it hasn't been released.
Specification PR: elastic/elasticsearch-specification#2411
New response format