-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ApiKey expiration time to audit log #103959
Add ApiKey expiration time to audit log #103959
Conversation
Pinging @elastic/es-security (Team:Security) |
Hi @jfreden, I've created a changelog YAML for you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, sorry for the delay!
For this one, we can go with a Security/Audit
label. Also, two follow ups, one related to audit logging, other generically to the addition of the new field (forgot about this one before):
- We should update audit event docs: https://www.elastic.co/guide/en/elasticsearch/reference/current/audit-event-types.html (under
change_apikey
and other event types where it matters) to reflect the new field - We might need to update the API spec -- this is used to generate ES client definitions. See this PR for an example: Add
active_only
flag definition to Get API key spec elasticsearch-specification#2371
...security/src/main/java/org/elasticsearch/xpack/security/audit/logfile/LoggingAuditTrail.java
Outdated
Show resolved
Hide resolved
...ity/src/test/java/org/elasticsearch/xpack/security/audit/logfile/LoggingAuditTrailTests.java
Outdated
Show resolved
Hide resolved
Thanks for the review!
Added it to this PR.
Will work on a separate PR for this. |
349518e
to
a053184
Compare
Follow up to PR: #103453