Skip to content

Commit

Permalink
Skip CBs in TransportBroadcastUnpromotableAction (#107681)
Browse files Browse the repository at this point in the history
`TransportBroadcastUnpromotableAction` derivatives are all small
management actions that we do not want to fail simply because a node is
under other heap pressure. Therefore with this commit we make them skip
the circuit-breaker check.
  • Loading branch information
DaveCTurner authored Apr 22, 2024
1 parent f77f982 commit f6a303f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,12 @@ public class TransportUnpromotableShardRefreshAction extends TransportBroadcastU
UnpromotableShardRefreshRequest,
ActionResponse.Empty> {

public static final String NAME = RefreshAction.NAME + "/unpromotable";
public static final String NAME = "indices:admin/refresh/unpromotable";

static {
// noinspection ConstantValue just for documentation
assert NAME.equals(RefreshAction.NAME + "/unpromotable");
}

private final IndicesService indicesService;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,8 @@ protected TransportBroadcastUnpromotableAction(
transportService.registerRequestHandler(
transportUnpromotableAction,
this.executor,
false,
false,
requestReader,
new UnpromotableTransportHandler()
);
Expand Down

0 comments on commit f6a303f

Please sign in to comment.