Skip to content

Commit

Permalink
Cannot skip tests named "values" (#115096) (#115108)
Browse files Browse the repository at this point in the history
When trying to use a gradle `skipTest` rule on tests named "values", we get a class-caste exception in Jackson.

This PR needs to rename this function for all versions of Elasticsearch that the `yamlRestCompatTestTransform` task will run on, so that later PRs that add skipTests will be able to pass. Since this test was added in 8.14, we must backport all the way back to there.

```
class com.fasterxml.jackson.databind.node.IntNode cannot be cast to class com.fasterxml.jackson.databind.node.ArrayNode (com.fasterxml.jackson.databind.node.IntNode and com.fasterxml.jackson.databind.node.ArrayNode are in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader$InstrumentingVisitableURLClassLoader @50337c96)
```
  • Loading branch information
craigtaverner authored Oct 18, 2024
1 parent 6c30c6c commit 09c8a68
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ setup:
- match: { values.1.0: "Payroll Specialist" }

---
values:
"values function":
- requires:
cluster_features: esql.agg_values
reason: "values is available in 8.14+"
Expand Down

0 comments on commit 09c8a68

Please sign in to comment.