Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17] Add examples to licensing APIs (#3420) #3425

Merged
merged 1 commit into from
Jan 3, 2025
Merged

[8.17] Add examples to licensing APIs (#3420) #3425

merged 1 commit into from
Jan 3, 2025
+135 −7

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 3, 2025

Backport

This will backport the following commits from main to 8.17:

Questions ?

Please refer to the Backport tool documentation

@lcawl
Add examples to licensing APIs (#3420)
96fc5a5 
Co-authored-by: István Zoltán Szabó <[email protected]>
(cherry picked from commit e153632)
@lcawl lcawl mentioned this pull request Jan 3, 2025
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

Following you can find the validation results for the APIs you have changed.

API Status Request Response
license.get_basic_status 🟢 3/3 3/3
license.get_trial_status 🟢 3/3 3/3
license.get 🟢 6/6 6/6
license.post_start_basic 🟢 5/5 5/5
license.post_start_trial 🟢 2/2 2/2
license.post 🟢 1/1 1/1

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team January 3, 2025 16:12
kilfoyle
kilfoyle reviewed Jan 3, 2025
View reviewed changes
Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐮

@lcawl lcawl merged commit 1728ff7 into 8.17 Jan 3, 2025
6 checks passed
@lcawl lcawl deleted the backport/8.17/pr-3420 branch January 3, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kilfoyle kilfoyle kilfoyle approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @kilfoyle