Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoiding container extension #3373

Merged
merged 1 commit into from
Dec 19, 2024
Merged

avoiding container extension #3373

merged 1 commit into from
Dec 19, 2024

Conversation

l-trotta
Copy link
Contributor

We merged #3107 which adds a class extending a container, which java doesn't support. I could add an exception in the generator, but since it's only two fields I'd prefer writing the extended class definition.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_geoip_database 🟢 1/1 1/1
ingest.delete_ip_location_database 🟢 1/1 1/1
ingest.delete_pipeline 🟢 15/15 15/15
ingest.geo_ip_stats 🟢 1/1 1/1
ingest.get_geoip_database 🟢 6/6 6/6
ingest.get_ip_location_database 🟢 7/7 7/7
ingest.get_pipeline 🟢 22/22 22/22
ingest.processor_grok 🟢 1/1 1/1
ingest.put_geoip_database 🟢 3/3 3/3
ingest.put_ip_location_database 🟢 4/4 4/4
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@l-trotta l-trotta merged commit 435b8e7 into main Dec 19, 2024
10 checks passed
@l-trotta l-trotta deleted the fixing-db-def branch December 19, 2024 15:45
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
github-actions bot pushed a commit that referenced this pull request Dec 19, 2024
l-trotta added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 435b8e7)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 435b8e7)

Co-authored-by: Laura Trotta <[email protected]>
l-trotta added a commit that referenced this pull request Dec 19, 2024
(cherry picked from commit 435b8e7)

Co-authored-by: Laura Trotta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants