Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update tag for data stream APIs #3369

Merged
merged 1 commit into from
Dec 19, 2024
Merged

[DOCS] Update tag for data stream APIs #3369

merged 1 commit into from
Dec 19, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 19, 2024

This PR adds @doc_tag data stream to some APIs to align with the grouping in https://www.elastic.co/guide/en/elasticsearch/reference/master/data-stream-apis.html

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.delete_data_stream 🟢 28/28 28/28
indices.downsample 🟢 1/1 1/1
indices.explain_data_lifecycle Missing test Missing test
indices.promote_data_stream Missing test Missing test
indices.put_data_lifecycle Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📇

@lcawl lcawl merged commit 476a546 into main Dec 19, 2024
11 checks passed
@lcawl lcawl deleted the data-stream-spec branch December 19, 2024 17:20
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3369-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 476a546b0fd7a85813e1e2ed350043f2cb4363cc
# Push it to GitHub
git push --set-upstream origin backport-3369-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3369-to-8.x.

Copy link
Contributor

The backport to 8.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.17 8.17
# Navigate to the new working tree
cd .worktrees/backport-8.17
# Create a new branch
git switch --create backport-3369-to-8.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 476a546b0fd7a85813e1e2ed350043f2cb4363cc
# Push it to GitHub
git push --set-upstream origin backport-3369-to-8.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.17

Then, create a pull request where the base branch is 8.17 and the compare/head branch is backport-3369-to-8.17.

lcawl added a commit that referenced this pull request Dec 19, 2024
@lcawl
Copy link
Contributor Author

lcawl commented Dec 19, 2024

💚 All backports created successfully

Status Branch Result
8.x

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Dec 19, 2024
@lcawl
Copy link
Contributor Author

lcawl commented Dec 19, 2024

💚 All backports created successfully

Status Branch Result
8.17

Questions ?

Please refer to the Backport tool documentation

lcawl added a commit that referenced this pull request Dec 19, 2024
lcawl added a commit that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants