Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] "local" parameter only in compatible cat requests (#3096) #3359

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

pquentin
Copy link
Member

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

* local parameter only in compatible cat requests

* fix import

* format

* regenerate output

* removed local from cat indices

(cherry picked from commit 2bf3907)

# Conflicts:
#	output/schema/validation-errors.json
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.allocation 🟢 12/12 12/12
cat.component_templates Missing test Missing test
cat.master 🟢 1/1 1/1
cat.nodeattrs 🟢 5/5 5/5
cat.pending_tasks 🟢 1/1 1/1
cat.plugins 🟢 2/2 2/2
cat.segments 🟢 9/9 9/9
cat.templates 🟢 17/17 17/17
cat.thread_pool 🟢 9/9 9/9

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
cat.aliases 🟢 30/30 30/30
cat.allocation 🟢 12/12 12/12
cat.component_templates Missing test Missing test
cat.master 🟢 1/1 1/1
cat.nodeattrs 🟢 5/5 5/5
cat.pending_tasks 🟢 1/1 1/1
cat.plugins 🟢 2/2 2/2
cat.segments 🟢 9/9 9/9
cat.templates 🟢 17/17 17/17
cat.thread_pool 🟢 9/9 9/9

You can validate these APIs yourself by using the make validate target.

@pquentin
Copy link
Member Author

Here's proof that this pull request applies to 8.x. I've also added local to cat aliases since it's supported in 8.x (but not in 9.0).

$ cd server/src/main/java/org/elasticsearch/rest/action/cat
$ grep 'paramAsBoolean("local"' *.java
RestAliasAction.java:            final var localParam = request.paramAsBoolean("local", false);
RestAllocationAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestCatComponentTemplateAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestMasterAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestNodeAttrsAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestPendingClusterTasksAction.java:        pendingClusterTasksRequest.local(request.paramAsBoolean("local", pendingClusterTasksRequest.local()));
RestPluginsAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestRepositoriesAction.java:        getRepositoriesRequest.local(request.paramAsBoolean("local", getRepositoriesRequest.local()));
RestSegmentsAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));
RestTemplatesAction.java:        getIndexTemplatesRequest.local(request.paramAsBoolean("local", getIndexTemplatesRequest.local()));
RestTemplatesAction.java:        getComposableTemplatesRequest.local(request.paramAsBoolean("local", getComposableTemplatesRequest.local()));
RestThreadPoolAction.java:        clusterStateRequest.local(request.paramAsBoolean("local", clusterStateRequest.local()));

@pquentin pquentin merged commit b881a5c into 8.x Dec 18, 2024
6 checks passed
@pquentin pquentin deleted the backport/8.x/pr-3096 branch December 18, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants