Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add find field structure and find messages structure APIs #3346

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Dec 18, 2024

@lcawl lcawl requested a review from a team December 18, 2024 00:14
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_field_structure 🟠 Missing type Missing type
text_structure.find_message_structure 🟠 Missing type Missing type
text_structure.find_structure 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
text_structure.find_field_structure 🟢 1/1 1/1
text_structure.find_message_structure 🟢 2/2 2/2
text_structure.find_structure 🟢 2/2 2/2

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🙂 Left a few type related suggestions.

/**
* The field that should be analyzed.
*/
field: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
field: string
field: Field

/**
* The name of the index that contains the analyzed field.
*/
index: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
index: string
index: IndexName

* If this parameter is not specified, the structure finder makes a decision about which field (if any) is the primary timestamp field.
* For structured text, it is not compulsory to have a timestamp in the text.
*/
timestamp_field?: string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
timestamp_field?: string
timestamp_field?: Field

* under the License.
*/
export class Response {
body: {}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is TBD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants