-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add find field structure and find messages structure APIs #3346
base: main
Are you sure you want to change the base?
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 🙂 Left a few type related suggestions.
/** | ||
* The field that should be analyzed. | ||
*/ | ||
field: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field: string | |
field: Field |
/** | ||
* The name of the index that contains the analyzed field. | ||
*/ | ||
index: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
index: string | |
index: IndexName |
* If this parameter is not specified, the structure finder makes a decision about which field (if any) is the primary timestamp field. | ||
* For structured text, it is not compulsory to have a timestamp in the text. | ||
*/ | ||
timestamp_field?: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
timestamp_field?: string | |
timestamp_field?: Field |
* under the License. | ||
*/ | ||
export class Response { | ||
body: {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is TBD?
This PR adds specifications based on the following documentation: