Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for EQL allow_partial_search_results #3342

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

luigidellaquila
Copy link
Contributor

Add spec for EQL allow_partial_search_results and for allow_partial_search_results parameters.

These allow EQL queries to keep running in case of shard failures.

Relates to elastic/elasticsearch#116388

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
eql.search 🟢 32/32 32/32

You can validate this API yourself by using the make validate target.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you 🙂

@luigidellaquila luigidellaquila merged commit 5987f79 into main Dec 18, 2024
17 of 18 checks passed
@luigidellaquila luigidellaquila deleted the luigidellaquila/eql_partial_results_spec branch December 18, 2024 08:57
Copy link
Contributor

The backport to 8.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-3342-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5987f79aed121f3657fc75769e494b26404d512b
# Push it to GitHub
git push --set-upstream origin backport-3342-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x

Then, create a pull request where the base branch is 8.x and the compare/head branch is backport-3342-to-8.x.

luigidellaquila added a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants