Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 8.17] Fix most ML APIs #3291

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[Backport 8.17] Fix most ML APIs #3291

merged 1 commit into from
Dec 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport ea3e9b6 from #3153.

* updated discovery node class

* correct import

* fixes around ml

* more ml fixes, tentative discoverynode fix

* more ml fixes

* even more ml fixes

* other ml fixes

* modeling discovery node

* correct discovery nodes optionals

* correcting types

* removed deprecated params

* Update specification/ml/_types/TrainedModel.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/TrainedModel.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/TrainedModel.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/TrainedModel.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/TrainedModel.ts

Co-authored-by: Quentin Pradet <[email protected]>

* addressing reviews

* Update specification/ml/_types/inference.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/inference.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/_types/inference.ts

Co-authored-by: Quentin Pradet <[email protected]>

* Update specification/ml/post_data/MlPostJobDataResponse.ts

Co-authored-by: Quentin Pradet <[email protected]>

* more review addressing

* merge fixes

---------

Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit ea3e9b6)
@github-actions github-actions bot requested review from a team as code owners December 12, 2024 09:49
@pquentin pquentin closed this Dec 12, 2024
@pquentin pquentin reopened this Dec 12, 2024
Copy link
Contributor Author

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.clear_trained_model_deployment_cache 🟢 1/1 1/1
ml.close_job 🟢 64/64 63/63
ml.delete_calendar_event 🟢 4/4 4/4
ml.delete_calendar_job 🟢 3/3 3/3
ml.delete_calendar 🟢 5/5 5/5
ml.delete_data_frame_analytics 🟢 2/2 2/2
ml.delete_datafeed 🟢 3/3 3/3
ml.delete_expired_data 🟢 5/5 5/5
ml.delete_filter 🟢 27/27 27/27
ml.delete_forecast 🟢 3/3 3/3
ml.delete_job 🟢 47/47 47/47
ml.delete_model_snapshot 🟢 2/2 2/2
ml.delete_trained_model_alias 🟢 3/3 3/3
ml.delete_trained_model 🟢 5/5 5/5
ml.estimate_model_memory 🟢 16/16 16/16
ml.evaluate_data_frame 🟢 15/15 15/15
ml.explain_data_frame_analytics 🟢 7/7 7/7
ml.flush_job 🟢 15/15 15/15
ml.forecast 🟢 1/1 1/1
ml.get_buckets 🟢 14/14 14/14
ml.get_calendar_events 🔴 15/15 5/15
ml.get_calendars 🟢 17/17 17/17
ml.get_categories 🟢 12/12 12/12
ml.get_data_frame_analytics_stats 🟢 12/12 12/12
ml.get_data_frame_analytics 🟢 17/17 17/17
ml.get_datafeed_stats 🟢 27/27 27/27
ml.get_datafeeds 🔴 20/20 9/20
ml.get_filters 🟢 13/13 13/13
ml.get_influencers 🟢 11/11 11/11
ml.get_job_stats 🟢 32/32 32/32
ml.get_jobs 🔴 31/31 22/31
ml.get_memory_stats 🟢 6/6 6/6
ml.get_model_snapshot_upgrade_stats 🟢 3/3 3/3
ml.get_model_snapshots 🟢 18/18 18/18
ml.get_overall_buckets 🟢 16/16 15/15
ml.get_records 🟢 8/8 8/8
ml.get_trained_models_stats 🔴 17/17 12/17
ml.get_trained_models 🟢 37/37 37/37
ml.infer_trained_model 🟢 10/10 10/10
ml.info 🟢 10/10 10/10
ml.open_job 🟢 83/83 83/83
ml.post_calendar_events 🔴 12/12 0/12
ml.post_data 🔴 9/11 18/18
ml.preview_data_frame_analytics 🟢 3/3 3/3
ml.preview_datafeed 🟢 17/17 17/17
ml.put_calendar_job 🟢 12/12 12/12
ml.put_calendar 🟢 135/135 135/135
ml.put_data_frame_analytics 🟢 33/33 33/33
ml.put_datafeed 🔴 71/71 53/71
ml.put_filter 🟢 27/27 27/27
ml.put_job 🔴 227/227 223/225
ml.put_trained_model_alias 🟢 13/13 13/13
ml.put_trained_model_definition_part 🟢 1/1 1/1
ml.put_trained_model_vocabulary 🟢 1/1 1/1
ml.put_trained_model 🔴 8/16 16/16
ml.reset_job 🟢 2/2 2/2
ml.revert_model_snapshot 🟢 2/2 2/2
ml.set_upgrade_mode 🟢 6/6 6/6
ml.start_data_frame_analytics 🟢 1/1 1/1
ml.start_datafeed 🟢 24/24 24/24
ml.start_trained_model_deployment 🟢 14/14 14/14
ml.stop_data_frame_analytics 🟢 5/5 5/5
ml.stop_datafeed 🟢 17/17 17/17
ml.stop_trained_model_deployment 🟢 10/10 10/10
ml.update_data_frame_analytics 🟢 2/2 2/2
ml.update_datafeed 🔴 7/7 2/7
ml.update_filter 🟢 3/3 3/3
ml.update_job 🟢 5/5 5/5
ml.update_model_snapshot 🟢 3/3 3/3
ml.update_trained_model_deployment 🟢 4/4 4/4
ml.upgrade_job_snapshot 🟢 3/3 3/3
ml.validate_detector 🟢 2/2 2/2
ml.validate 🟢 3/3 3/3

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit dc1aa45 into 8.17 Dec 13, 2024
7 checks passed
@pquentin pquentin deleted the backport-3153-to-8.17 branch December 13, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants