Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing master timeout #3252

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Added missing master timeout #3252

merged 1 commit into from
Dec 5, 2024

Conversation

l-trotta
Copy link
Contributor

@l-trotta l-trotta commented Dec 5, 2024

Removes validation errors in #3251

@l-trotta l-trotta requested review from pquentin and flobernd December 5, 2024 09:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
indices.exists_alias 🟢 37/37 37/37
indices.get_alias 🟢 68/68 68/68

You can validate these APIs yourself by using the make validate target.

pquentin
pquentin approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Note that you could also have directly pushed those changes to #3251. Maybe this way helps with backports?

@l-trotta
Copy link
Contributor Author

l-trotta commented Dec 5, 2024

the problem with pushing directly is that at some point during the night it reloads the changes and I lose the commits

@l-trotta
Copy link
Contributor Author

l-trotta commented Dec 5, 2024

also this is just for 9, no backports

@l-trotta l-trotta merged commit 5485843 into main Dec 5, 2024
7 checks passed
@l-trotta l-trotta deleted the fixing-validation branch December 5, 2024 15:25
@pquentin pquentin mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@flobernd flobernd Awaiting requested review from flobernd

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l-trotta @pquentin