Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git recordings when running make validate #3179

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 26, 2024

With the corresponding clients-flight-recorder pull request, this requires running make validate-no-cache instead of simply make validate. For example:

❯ make validate-no-cache api=xpack.info branch=main
Validating endpoints
Validating xpack.info
xpack.info request has been successfully validated!

✔ 8 out of 8 test request cases are passing.
✔ 4 out of 4 test response cases are passing.

@pquentin pquentin requested a review from a team as a code owner November 26, 2024 06:40
@pquentin pquentin merged commit 2942c94 into main Nov 26, 2024
9 checks passed
@pquentin pquentin deleted the make-validate-git-recordings branch November 26, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants