Add rule_type_counts to QueryRulesetListResponse spec #3150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
1 similar comment
|
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
pquentin
approved these changes
Nov 19, 2024
|
@pquentin good catch - I added labels to backport to 8.16 and 8.x. Is that sufficient? |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Add rule_type_counts to QueryRulesetListResponse spec * Generate schema (cherry picked from commit b74dd77)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
* Add rule_type_counts to QueryRulesetListResponse spec * Generate schema (cherry picked from commit b74dd77)
|
@kderusso Yes, that's enough to open the pull request. I closed/reopened them, which is an optional trick I use to get CI to run, which confirmed this API was fixed. And then I approved, which gave me the green merge button. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
rule_type_countsadded in elastic/elasticsearch#116357 to the specification