Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the inference API stability to stable #3141

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update the inference API stability to stable #3141

merged 2 commits into from
Nov 19, 2024

Conversation

davidkyle
Copy link
Member

The Inference API was GA'd in 8.16

@davidkyle davidkyle requested a review from a team as a code owner November 18, 2024 10:23
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
pquentin
pquentin approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@pquentin
Copy link
Member

Sorry that I missed that when merging #3138.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete ⚪ Missing test Missing test
inference.get 🟢 1/1 1/1
inference.inference ⚪ Missing test Missing test
inference.put ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@davidkyle davidkyle merged commit e6ff1e2 into main Nov 19, 2024
7 checks passed
@davidkyle davidkyle deleted the ga-inference-api branch November 19, 2024 07:35
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@davidkyle @github-actions
Set inference API stability to stable (#3141)
3f03303 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit e6ff1e2)
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
@davidkyle @github-actions
Set inference API stability to stable (#3141)
76c9feb 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit e6ff1e2)
@github-actions github-actions bot mentioned this pull request Nov 19, 2024
Merged
l-trotta pushed a commit that referenced this pull request Nov 19, 2024
@github-actions @davidkyle
Set inference API stability to stable (#3141) (#3148)
a1d3320 
Co-authored-by: Quentin Pradet <[email protected]>
(cherry picked from commit e6ff1e2)

Co-authored-by: David Kyle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pquentin pquentin pquentin approved these changes

@dan-rubinstein dan-rubinstein Awaiting requested review from dan-rubinstein

Assignees
No one assigned
Labels
backport 8.x backport 8.16 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidkyle @pquentin @l-trotta