Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenAPI] Edits Logstash pipeline APIs #3073

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[OpenAPI] Edits Logstash pipeline APIs #3073

merged 3 commits into from
Dec 17, 2024
+152 −97

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 23, 2024 •
edited
Loading

Relates to #2635, #3226

This PR edits the descriptions for the logstash APIs, copying the text from https://www.elastic.co/guide/en/elasticsearch/reference/master/logstash-apis.html

Before

image

After

image

@lcawl lcawl mentioned this pull request Oct 23, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
logstash.delete_pipeline ⚪ Missing test Missing test
logstash.get_pipeline ⚪ Missing test Missing test
logstash.put_pipeline ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from karenzone October 23, 2024 21:55
@lcawl lcawl marked this pull request as ready for review October 23, 2024 21:55
@lcawl lcawl mentioned this pull request Dec 5, 2024
Closed
23 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
logstash.delete_pipeline ⚪ Missing test Missing test
logstash.get_pipeline ⚪ Missing test Missing test
logstash.put_pipeline ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

karenzone
karenzone approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this work, lcawl.

@lcawl lcawl merged commit dd538c9 into main Dec 17, 2024
8 checks passed
@lcawl lcawl deleted the lcawl/logstash-apis branch December 17, 2024 02:31
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@lcawl @github-actions
[OpenAPI] Edits Logstash pipeline APIs (#3073)
3d7d7ea 
(cherry picked from commit dd538c9)
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@lcawl @github-actions
[OpenAPI] Edits Logstash pipeline APIs (#3073)
9de6ec6 
(cherry picked from commit dd538c9)
@github-actions github-actions bot mentioned this pull request Dec 17, 2024
Open
lcawl added a commit that referenced this pull request Dec 17, 2024
@github-actions @lcawl
[OpenAPI] Edits Logstash pipeline APIs (#3073) (#3333)
f7a774d 
(cherry picked from commit dd538c9)

Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karenzone karenzone karenzone approved these changes

Assignees
No one assigned
Labels
backport 8.x backport 8.17 OpenAPI specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lcawl @karenzone