Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenAPI] Edits dangling index APIs #3055

Merged
merged 3 commits into from
Oct 23, 2024
Merged

[OpenAPI] Edits dangling index APIs #3055

merged 3 commits into from
Oct 23, 2024

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Oct 23, 2024

Relates to #2635

This PR updates the tags and summaries for the dangling indices APIs (copied from https://www.elastic.co/guide/en/elasticsearch/reference/master/dangling-indices-list.html, https://www.elastic.co/guide/en/elasticsearch/reference/master/dangling-index-delete.html, and https://www.elastic.co/guide/en/elasticsearch/reference/master/dangling-index-import.html).
It also adds the @doc_tag property so that the APIs are grouped with the other index APIs.

@lcawl lcawl requested a review from esdocs October 23, 2024 02:14
@lcawl lcawl marked this pull request as ready for review October 23, 2024 02:14
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
dangling_indices.delete_dangling_index Missing test Missing test
dangling_indices.import_dangling_index Missing test Missing test
dangling_indices.list_dangling_indices Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
dangling_indices.delete_dangling_index Missing test Missing test
dangling_indices.import_dangling_index Missing test Missing test
dangling_indices.list_dangling_indices Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl merged commit 4c353a9 into main Oct 23, 2024
6 checks passed
@lcawl lcawl deleted the lcawl/indices branch October 23, 2024 15:59
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
github-actions bot pushed a commit that referenced this pull request Oct 23, 2024
lcawl pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants