Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing fields to CreateFollowIndexRequest #3042

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Oct 22, 2024

Add missing data_stream_name and settings field to CreateFollowIndexRequest.

As well update some fields to use the correct types and add documentation.

@flobernd flobernd requested review from pquentin, l-trotta and a team October 22, 2024 12:42
Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
ccr.follow Missing test Missing test

You can validate this API yourself by using the make validate target.

@flobernd flobernd force-pushed the fix-ccr-follow-request branch from c1ee6cf to c998487 Compare October 22, 2024 12:55
@flobernd flobernd changed the title Add data_stream_name field to CreateFollowIndexRequest Add missing fields to CreateFollowIndexRequest Oct 22, 2024
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ccr.follow_info Missing test Missing test
ccr.follow Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@flobernd flobernd merged commit d633341 into main Oct 22, 2024
6 checks passed
@flobernd flobernd deleted the fix-ccr-follow-request branch October 22, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants