Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds ingest API request and response examples #2996

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Conversation

szabosteve
Copy link
Contributor

Overview

Related to #2482.
This PR adds request and response examples to the ingest API.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.get_pipeline 🟢 22/22 22/22
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

github-actions bot commented Oct 9, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.get_pipeline 🟢 22/22 22/22
ingest.put_pipeline 🟢 59/59 59/59
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.get_pipeline 🟢 22/22 22/22
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.get_pipeline 🟢 22/22 22/22
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.get_pipeline 🟢 22/22 22/22
ingest.put_pipeline 🟢 60/60 60/60
ingest.simulate 🟢 10/10 10/10

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit 2045505 into main Dec 10, 2024
7 checks passed
@szabosteve szabosteve deleted the api-examples-pt8 branch December 10, 2024 08:52
github-actions bot pushed a commit that referenced this pull request Dec 10, 2024
Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 2045505)
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 2045505)
szabosteve added a commit that referenced this pull request Dec 11, 2024
Co-authored-by: Lisa Cawley <[email protected]>
(cherry picked from commit 2045505)

Co-authored-by: István Zoltán Szabó <[email protected]>
lcawl added a commit that referenced this pull request Dec 12, 2024
Co-authored-by: István Zoltán Szabó <[email protected]>
Co-authored-by: Lisa Cawley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants