-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @doc_tag to override default tag behaviour #2961
Conversation
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
1 similar comment
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
This reverts commit dc43500.
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've left a code suggestion to avoid using expect
which simplifies a bit the code.
Co-authored-by: Laurent Saint-Félix <[email protected]>
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
1 similar comment
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.x 8.x
# Navigate to the new working tree
cd .worktrees/backport-8.x
# Create a new branch
git switch --create backport-2961-to-8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5f59dc31bbf456d0c1f5f3020ce36091b7da70cd
# Push it to GitHub
git push --set-upstream origin backport-2961-to-8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.x Then, create a pull request where the |
Co-authored-by: Laurent Saint-Félix <[email protected]>
Co-authored-by: Laurent Saint-Félix <[email protected]>
Fixes #2310
This PR adds a @doc_tag modifier so that we can override the default operation-level tags that are based on the namespace.
For example, we can use it to put a "data stream" tag on the create data stream API to match its grouping in the existing docs (https://www.elastic.co/guide/en/elasticsearch/reference/current/indices-create-data-stream.html) rather than the default "indices" value.