Java issues batch 8 #2959
Merged
Java issues batch 8 #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
pquentin
approved these changes
Oct 1, 2024
Comment on lines
20
to
25
| export class StepKey { | ||
| action: string | ||
| name: string | ||
| // action and name are optional in case they are used in next_step | ||
| action?: string | ||
| name?: string | ||
| phase: string | ||
| } |
There was a problem hiding this comment.
Should we make a NextStepKey class? Just wondering, really.
There was a problem hiding this comment.
was wondering the same, that would be a breaking change though and it would have to wait
There was a problem hiding this comment.
Agreed! Can you please add it to #2973?
And feel free to merge this pull request
There was a problem hiding this comment.
Not 100% related, but juding from the documentation, it seems that both, current_step and next_step should be required.
We currently model them as optional:
/**
* @rest_spec_name ilm.move_to_step
* @availability stack since=6.6.0 stability=stable
*/
export interface Request extends RequestBase {
path_parts: {
index: IndexName
}
body: {
current_step?: StepKey
next_step?: StepKey
}
}There was a problem hiding this comment.
good catch! I'll remove the optional
flobernd
approved these changes
Oct 1, 2024
11 tasks
|
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.15 8.15
# Navigate to the new working tree
cd .worktrees/backport-8.15
# Create a new branch
git switch --create backport-2959-to-8.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3b1143a5a96fc7596af96485bccca492798d6f0e
# Push it to GitHub
git push --set-upstream origin backport-2959-to-8.15
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.15Then, create a pull request where the |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* [877] ngram and edge tokenizer optional values * [880] _shards optional because of wait_for_completion * [881] added missing allow_custom_routing * [883] action and name optional next_step * both steps mandatory in move to step request (cherry picked from commit 3b1143a)
l-trotta
added a commit
that referenced
this pull request
Oct 1, 2024
* [877] ngram and edge tokenizer optional values * [880] _shards optional because of wait_for_completion * [881] added missing allow_custom_routing * [883] action and name optional next_step * both steps mandatory in move to step request (cherry picked from commit 3b1143a) Co-authored-by: Laura Trotta <[email protected]>
l-trotta
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wait_for_competion, so the response should be optional to handle bothwait_for_competioncases.allow_custom_routingto PutIndexTemplate. server code -failure_storeis internal.actionandnameare optional. not super clear from the server code (it's all String), but the documentation confirms it (and DevTools test as well).Everything should be safe to backport to 8.x and 8.15