Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing default ML query descriptions #2917

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add missing default ML query descriptions #2917

wants to merge 13 commits into from
+35 −23

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 19, 2024 •
edited
Loading

Per #2918, where the ML anomaly detection and data frame analytic jobs have an additional bit of info about default queries, that detail is lost since they're re-using the shared QueryContainer description. As a work-around for now I've moved that info into the API description.

@lcawl lcawl added the OpenAPI label Sep 19, 2024
@lcawl lcawl changed the title Add more x-abbreviated overlays in machine learning APIs Add x-abbreviated overlays in graph, script, async search, search, and ML APIs Sep 20, 2024
@lcawl lcawl marked this pull request as ready for review September 20, 2024 02:03
@lcawl lcawl requested a review from szabosteve September 20, 2024 02:03
@lcawl lcawl marked this pull request as draft September 20, 2024 05:22
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

2 similar comments
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title Add x-abbreviated overlays in graph, script, async search, search, and ML APIs Add x-abbreviated overlay for QueryContainer; add missing default ML query descriptions Sep 20, 2024
@lcawl lcawl marked this pull request as ready for review September 20, 2024 19:37
@lcawl lcawl requested review from a team as code owners September 20, 2024 19:37
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as draft October 1, 2024 23:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl changed the title Add x-abbreviated overlay for QueryContainer; add missing default ML query descriptions Add missing default ML query descriptions Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ml.put_data_frame_analytics 🔴 32/33 32/33
ml.put_datafeed 🔴 70/71 53/71
ml.put_job 🔴 219/227 223/225

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl marked this pull request as ready for review October 17, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabosteve szabosteve Awaiting requested review from szabosteve

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 8.x OpenAPI specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lcawl