-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Query Rules validation #2677
Conversation
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you 🙂
Since this is not urgent, I'd like to wait a few working days before merging in order to give @kderusso a change to review this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving this!
* Add missing priority field * Add fuzzy criteria type * Allow criteria and rules to be single objects * Fix type of rule_criteria_types_counts * Run make contrib (cherry picked from commit 95e7482)
* Add missing priority field * Add fuzzy criteria type * Allow criteria and rules to be single objects * Fix type of rule_criteria_types_counts * Run make contrib (cherry picked from commit 95e7482) Co-authored-by: Quentin Pradet <[email protected]>
For reference, now that we can use Query Rules YAML tests, here is the current validation status:
delete_rule
delete_ruleset
get_rule
get_ruleset
list_rulesets
put_rule
put_ruleset
With only looking at docs and validation errors (not the code), I've fixed validation of all APIs in four commits:
0ce3f1c
(#2677) Add missing priority field0053366
(#2677) Add fuzzy criteria typec7d91cb
(#2677) Allow criteria and rules to be single objects. I'm not sure we actually want to allow that, but the YAML tests make use of it.8a54468
(#2677) Fix type of rule_criteria_type_counts