Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deserialization for PutSynonymResponse #2577

Merged

Conversation

GeorgeCiachir
Copy link
Contributor

@GeorgeCiachir GeorgeCiachir commented May 24, 2024

The ReloadResult should be a member of the PutResponseSynonym, instead of the ReloadDetails, so that the PutResponseSynonym is properly serialized.
Current behavior is that it throws a MissingRequiredPropertyException

Closes elastic/elasticsearch-java#784
Closes #2578

@pquentin
Copy link
Member

Thanks @GeorgeCiachir for this. Unfortunately, our CI is not setup to accept external contributions due to security concerns, so I opened #2578 to get validation running. Which fixed validation here, so now this can be reviewed.

@GeorgeCiachir
Copy link
Contributor Author

Thanks @GeorgeCiachir for this. Unfortunately, our CI is not setup to accept external contributions due to security concerns, so I opened #2578 to get validation running. Which fixed validation here, so now this can be reviewed.

Thanks, @pquentin
I was wondering what's up with the validation because I also wanted to validate from my local, but I got a 404 on https://github.com/elastic/clients-flight-recorder.git.
Maybe the Readme should also be updated and specify the validation part can only be performed by the Elastic team members. I mean here: https://github.com/elastic/elasticsearch-specification/tree/main?tab=readme-ov-file#how-to-validate-the-specification

@l-trotta
Copy link
Contributor

LGTM, good job!

@l-trotta l-trotta merged commit 3672611 into elastic:main May 28, 2024
11 of 12 checks passed
github-actions bot pushed a commit that referenced this pull request May 28, 2024
l-trotta pushed a commit that referenced this pull request May 28, 2024
(cherry picked from commit 3672611)

Co-authored-by: George Ciachir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PutSynonymResponse: Failed to decode response
3 participants