-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deserialization for PutSynonymResponse #2577
Fix deserialization for PutSynonymResponse #2577
Conversation
Thanks @GeorgeCiachir for this. Unfortunately, our CI is not setup to accept external contributions due to security concerns, so I opened #2578 to get validation running. Which fixed validation here, so now this can be reviewed. |
Thanks, @pquentin |
LGTM, good job! |
(cherry picked from commit 3672611)
(cherry picked from commit 3672611) Co-authored-by: George Ciachir <[email protected]>
The ReloadResult should be a member of the PutResponseSynonym, instead of the ReloadDetails, so that the PutResponseSynonym is properly serialized.
Current behavior is that it throws a MissingRequiredPropertyException
Closes elastic/elasticsearch-java#784
Closes #2578