-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from STACK_VERSION to SNAPSHOT_BRANCH #2536
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l-trotta
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Following you can find the validation results for the API you have changed.
You can validate this API yourself by using the |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 9e0db88)
github-actions bot
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 9e0db88)
l-trotta
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 9e0db88) Co-authored-by: Quentin Pradet <[email protected]>
l-trotta
pushed a commit
that referenced
this pull request
Apr 30, 2024
(cherry picked from commit 9e0db88) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the changes in clients-flight-recorder.
The sed change can be tested withSince we use the branch name now, we can get that from GitHub Actions and don't need to bump anymore.VERSION=8.13 .ci/bump.sh
. (I would appreciate someone testing with BSD sed, as I tried to make it compatible which can make local testing easier.)I had to make a random change to trigger validation.