Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from STACK_VERSION to SNAPSHOT_BRANCH #2536

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Move from STACK_VERSION to SNAPSHOT_BRANCH #2536

merged 5 commits into from
Apr 30, 2024

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Apr 29, 2024

Following the changes in clients-flight-recorder.

The sed change can be tested with VERSION=8.13 .ci/bump.sh. (I would appreciate someone testing with BSD sed, as I tried to make it compatible which can make local testing easier.) Since we use the branch name now, we can get that from GitHub Actions and don't need to bump anymore.

I had to make a random change to trigger validation.

@pquentin pquentin requested a review from a team as a code owner April 29, 2024 13:12
Copy link
Contributor

@l-trotta l-trotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

Following you can find the validation results for the API you have changed.

API Status Request Response
indices.create 🔴 863/879 878/879

You can validate this API yourself by using the make validate target.

@pquentin pquentin merged commit 9e0db88 into main Apr 30, 2024
6 checks passed
@pquentin pquentin deleted the snapshot-branch branch April 30, 2024 08:27
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
l-trotta pushed a commit that referenced this pull request Apr 30, 2024
(cherry picked from commit 9e0db88)

Co-authored-by: Quentin Pradet <[email protected]>
l-trotta pushed a commit that referenced this pull request Apr 30, 2024
(cherry picked from commit 9e0db88)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants