Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding synonyms set to filters #2515

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Adding synonyms set to filters #2515

merged 1 commit into from
Apr 16, 2024

Conversation

l-trotta
Copy link
Contributor

SynonymGraphTokenFilter and SynonymTokenFilter should have the synonyms_set field.

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@l-trotta l-trotta merged commit 74ddd7c into main Apr 16, 2024
7 checks passed
@l-trotta l-trotta deleted the add-syn-set branch April 16, 2024 10:21
Copy link
Contributor

The backport to 7.17 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.17 7.17
# Navigate to the new working tree
cd .worktrees/backport-7.17
# Create a new branch
git switch --create backport-2515-to-7.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74ddd7cba66e253e8baa39909c7c37ca44329576
# Push it to GitHub
git push --set-upstream origin backport-2515-to-7.17
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.17

Then, create a pull request where the base branch is 7.17 and the compare/head branch is backport-2515-to-7.17.

Copy link
Contributor

The backport to 8.13 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-8.13 8.13
# Navigate to the new working tree
cd .worktrees/backport-8.13
# Create a new branch
git switch --create backport-2515-to-8.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74ddd7cba66e253e8baa39909c7c37ca44329576
# Push it to GitHub
git push --set-upstream origin backport-2515-to-8.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-8.13

Then, create a pull request where the base branch is 8.13 and the compare/head branch is backport-2515-to-8.13.

l-trotta added a commit that referenced this pull request Apr 16, 2024
l-trotta added a commit that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants