Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use alias types in connectors API where it makes sense #2507

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Use alias types in connectors API where it makes sense #2507

merged 1 commit into from
Apr 17, 2024

Conversation

flobernd
Copy link
Member

@flobernd flobernd commented Apr 15, 2024 •
edited
Loading

Use alias types in connectors API where it makes sense

jedrazb
jedrazb approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@jedrazb jedrazb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flobernd flobernd force-pushed the connectors-use-indexname-alias branch from 9e0b112 to dfc4968 Compare April 15, 2024 13:37
@flobernd flobernd changed the title Use IndexName in connectors API Use alias types in connectors API where it makes sense Apr 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
connector.check_in ⚪ Missing test Missing test
connector.delete ⚪ Missing test Missing test
connector.get ⚪ Missing test Missing test
connector.last_sync ⚪ Missing test Missing test
connector.list ⚪ Missing test Missing test
connector.post ⚪ Missing test Missing test
connector.put ⚪ Missing test Missing test
connector.update_api_key_id ⚪ Missing test Missing test
connector.update_configuration ⚪ Missing test Missing test
connector.update_error ⚪ Missing test Missing test
connector.update_filtering ⚪ Missing test Missing test
connector.update_index_name ⚪ Missing test Missing test
connector.update_name ⚪ Missing test Missing test
connector.update_native ⚪ Missing test Missing test
connector.update_pipeline ⚪ Missing test Missing test
connector.update_scheduling ⚪ Missing test Missing test
connector.update_service_type ⚪ Missing test Missing test
connector.update_status ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@flobernd
Copy link
Member Author

Sorry, I accidentally force pushed to the wrong branch 😵‍💫 I've changed more string occurences to the fitting alias type. This should probably get reviewed another time.

@flobernd flobernd requested review from jedrazb and Anaethelion April 15, 2024 13:39
@flobernd flobernd mentioned this pull request Apr 17, 2024
Merged
@flobernd flobernd merged commit aa52dc7 into main Apr 17, 2024
6 checks passed
@flobernd flobernd deleted the connectors-use-indexname-alias branch April 17, 2024 10:31
jedrazb pushed a commit that referenced this pull request Apr 30, 2024
@flobernd
Use alias types in connectors API where it makes sense (#2507)
e0f519a 
(cherry picked from commit aa52dc7)
@jedrazb jedrazb mentioned this pull request Apr 30, 2024
Merged
@jedrazb
Copy link
Member

jedrazb commented Apr 30, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.14

Questions ?

Please refer to the Backport tool documentation

jedrazb added a commit that referenced this pull request Apr 30, 2024
@jedrazb @flobernd
Use alias types in connectors API where it makes sense (#2507) (#2539)
4e3074b 
(cherry picked from commit aa52dc7)

Co-authored-by: Florian Bernd <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedrazb jedrazb jedrazb approved these changes

@swallez swallez Awaiting requested review from swallez

@Anaethelion Anaethelion Awaiting requested review from Anaethelion

Assignees
No one assigned
Labels
enhancement specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flobernd @jedrazb @Anaethelion