Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define global WithNullValue<T> type #2497

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

jedrazb
Copy link
Member

@jedrazb jedrazb commented Apr 9, 2024

This defines a generic WithNullValue type that allows for semantic null assignment.

Connectors type declarations would use this type in several different places so I'm proposing to make it a global utils type.

@jedrazb jedrazb requested a review from a team as a code owner April 9, 2024 12:45
@jedrazb jedrazb requested a review from swallez April 9, 2024 12:46
Copy link
Member

@swallez swallez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jedrazb jedrazb merged commit 17b7bcb into main Apr 9, 2024
5 checks passed
@jedrazb jedrazb deleted the add-withnullvalue-global-type-definition branch April 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants