Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rerank renamed id to index #2481

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Rerank renamed id to index #2481

merged 1 commit into from
Apr 3, 2024

Conversation

maxhniebergall
Copy link
Member

Following on the review of this PR, I am renaming the rerank parameter id to index. #2479

@maxhniebergall maxhniebergall requested a review from davidkyle April 3, 2024 17:50
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model ⚪ Missing test Missing test
inference.get_model 🟢 1/1 1/1
inference.inference ⚪ Missing test Missing test
inference.put_model ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@maxhniebergall maxhniebergall enabled auto-merge (squash) April 3, 2024 17:57
davidkyle
davidkyle approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxhniebergall maxhniebergall merged commit 345c58f into main Apr 3, 2024
6 checks passed
@maxhniebergall maxhniebergall deleted the rerankRenameId branch April 3, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxhniebergall @davidkyle