-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query and Get API Key Information endpoints support for profile uid #2473
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, can you split typed_keys in another PR if that is back ported into 8.13.
Also can you run a make spec-format-fix
for code style?
potential conflict with typed_keys backport?
Thank you for reviewing @Anaethelion !
I haven't yet backported the
Can you please handle this in my place, as I don't have the tools installed? |
7c4c42c
to
24c64e7
Compare
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
This PR changes the client spec to support the new
with_profile_uid
request parameter, as well as thecorresponding
profile_uid
response field in the returned API key information,for the Get and Query API key endpoints, from elastic/elasticsearch#106531 .
Separately it adds support for the
typed_keys
request parameter tothe Query API key endpoint, from elastic/elasticsearch#106873
It also exposes the
realm_type
field in the returned API key information,from elastic/elasticsearch#105629