Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Completion result and task type to the Inference API spec #2471

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

timgrein
Copy link
Contributor

This PR adds the new completion task type and the result to the specification.

Completion result example:

{ 
  "completion": [ 
     { 
       "result": "..." 
      } 
   ] 
} 

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.delete_model Missing test Missing test
inference.get_model 🟢 1/1 1/1
inference.inference Missing test Missing test
inference.put_model Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timgrein timgrein merged commit 8b12f48 into main Mar 28, 2024
6 checks passed
@timgrein timgrein deleted the timgrein/inference-api-completion-result-spec branch March 28, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants