Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict query type when querying API keys #2460

Merged
merged 3 commits into from
Mar 14, 2024

Conversation

albertzaharovits
Copy link
Contributor

Only a subset of query types are supported when querying API keys.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only left a suggestion for the missing annotations.

Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
security.query_api_keys 🔴 13/14 0/14

You can validate these APIs yourself by using the make validate target.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Anaethelion Anaethelion merged commit 6c85668 into main Mar 14, 2024
7 checks passed
@Anaethelion Anaethelion deleted the query-api-key-type-restricted-spec branch March 14, 2024 16:34
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
* Ok?

* Update specification/security/query_api_keys/types.ts

Co-authored-by: Laurent Saint-Félix <[email protected]>

* make contrib

---------

Co-authored-by: Laurent Saint-Félix <[email protected]>
(cherry picked from commit 6c85668)
Anaethelion pushed a commit that referenced this pull request Mar 14, 2024
* Ok?

* Update specification/security/query_api_keys/types.ts

Co-authored-by: Laurent Saint-Félix <[email protected]>

* make contrib

---------

Co-authored-by: Laurent Saint-Félix <[email protected]>
(cherry picked from commit 6c85668)

Co-authored-by: Albert Zaharovits <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants