-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing codegen_name
annotations to all value bodied responses
#2457
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check if this causes breaking changes on the Java client...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'd like @Anaethelion to also have a look from the Go client perspective.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no impact on my part.
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
In the .NET client, these value-type bodies will be wrapped in a common response type like e.g.:
In order to properly auto-generate the required body property (e.g.
Data
in this case) with a meaningful name, all of these bodies must be annotated withcodegen_name
attributes.It would be nice having a compiler check for this rule in the future.