Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for aggregations in Security's Query API Key Information API #2455

Merged
merged 5 commits into from
Mar 14, 2024

Conversation

albertzaharovits
Copy link
Contributor

In 8.13 ES's Query API Key Information API added support for aggregations.
This should reflect that change in the request/response of the specification.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since containers are property based unions I'd recommend we create the relevant versions with only the supported subset to avoid misleading users.

Copy link
Contributor

@Anaethelion Anaethelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few changes are still needed.

@Anaethelion Anaethelion merged commit 221884f into elastic:main Mar 14, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
…2455)

* Done

* Restrict aggs types

* types.ts

* make contrib

---------

Co-authored-by: Laurent Saint-Félix <[email protected]>
(cherry picked from commit 221884f)
@albertzaharovits albertzaharovits deleted the query-api-support-for-aggs branch March 14, 2024 14:30
Anaethelion pushed a commit that referenced this pull request Mar 14, 2024
…2455) (#2459)

* Done

* Restrict aggs types

* types.ts

* make contrib

---------

Co-authored-by: Laurent Saint-Félix <[email protected]>
(cherry picked from commit 221884f)

Co-authored-by: Albert Zaharovits <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants