Java client issues batch 2

[l-trotta]

Fixes provided in this PR:

• 744, 376: ExecuteEnrichPolicyResponse should have status optional, otherwise when called with waitForCompletion=false the parsing will fail
• 317: not really the issue described (that one was already fixed), but transient_metadata should be a map, not a single field class. Starting a basic elasticsearch instance with xpack.security.enabled and a password and trying to call client.security().getRole() will otherwise fail.
• 379: *_size_bytes fields should be long, not integer
• 394: GeoPoint is missing fields
• 403: source in InlineGet should be optional
• 409: stored_field in InnerHits should be stored_fields
• 450: RankFeaturesProperty should have positive_score_impact like RankFeatureProperty does
• 754: dims should be optional for dense vectors

[Anaethelion]

Unsure about GeoPointProperty, it seems to fit the server description, maybe these should be a level higher.

[Anaethelion]

This should be a Dictionary<string, UserDefinedValue>
https://github.com/elastic/elasticsearch/blob/46beceb18024a27a57449de6e45897a0fb1d890b/x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authz/RoleDescriptor.java#L68

[l-trotta]

@Anaethelion I also applied the same change to the security spec since the class should be the same, is it correct?

[swallez]

Yes. Also remove TransientMetadataConfig that is now useless.

[Anaethelion]

Agreed.

[github-actions]

Following you can find the validation results for the APIs you have changed.

API	Status	Request	Response
enrich.execute_policy	🟢	7/7	7/7
indices.data_streams_stats	🟢	4/4	4/4
search	🔴	1787/1849	1755/1831
security.activate_user_profile	🟢	8/8	8/8
security.authenticate	🔴	29/29	23/29
security.bulk_update_api_keys	🟠	Missing type	Missing type
security.change_password	🟢	9/9	9/9
security.clear_api_key_cache	🟢	13/13	13/13
security.clear_cached_privileges	🟢	3/3	3/3
security.clear_cached_realms	🟢	1/1	1/1
security.clear_cached_roles	🟢	2/2	2/2
security.clear_cached_service_tokens	🟢	4/4	4/4
security.create_api_key	🟢	55/55	46/46
security.create_cross_cluster_api_key	🟠	Missing type	Missing type
security.create_service_token	🟢	3/3	3/3
security.delete_privileges	🟢	6/6	6/6
security.delete_role_mapping	🟢	9/9	9/9
security.delete_role	🟢	8/8	8/8
security.delete_service_token	⚪	Missing test	Missing test
security.delete_user	🔴	9/9	8/9
security.disable_user_profile	🟢	1/1	1/1
security.disable_user	🟢	3/3	3/3
security.enable_user_profile	🟢	1/1	1/1
security.enable_user	🟢	4/4	4/4
security.enroll_kibana	⚪	Missing test	Missing test
security.enroll_node	⚪	Missing test	Missing test
security.get_api_key	🔴	37/37	12/37
security.get_builtin_privileges	🟢	2/2	2/2
security.get_privileges	🔴	12/12	11/12
security.get_role_mapping	🔴	18/18	10/18
security.get_role	🟢	20/20	20/20
security.get_service_accounts	⚪	Missing test	Missing test
security.get_service_credentials	🟢	1/1	1/1
security.get_settings	🟠	Missing type	Missing type
security.get_token	🟢	25/25	24/24
security.get_user_privileges	🟢	7/7	7/7
security.get_user_profile	🟢	8/8	8/8
security.get_user	🟢	25/25	25/25
security.grant_api_key	🔴	7/7	5/7
security.has_privileges_user_profile	🟢	3/3	3/3
security.has_privileges	🔴	24/24	22/24
security.invalidate_api_key	🔴	12/12	10/12
security.invalidate_token	🟢	11/11	11/11
security.oidc_authenticate	🟠	Missing type	Missing type
security.oidc_logout	🟠	Missing type	Missing type
security.oidc_prepare_authentication	🟠	Missing type	Missing type
security.put_privileges	🔴	10/10	9/10
security.put_role_mapping	🔴	2/11	11/11
security.put_role	🟢	39/39	38/38
security.put_user	🔴	48/48	46/47
security.query_api_keys	🔴	13/13	0/13
security.saml_authenticate	⚪	Missing test	Missing test
security.saml_complete_logout	⚪	Missing test	Missing test
security.saml_invalidate	⚪	Missing test	Missing test
security.saml_logout	⚪	Missing test	Missing test
security.saml_prepare_authentication	⚪	Missing test	Missing test
security.saml_service_provider_metadata	⚪	Missing test	Missing test
security.suggest_user_profiles	🟢	1/1	1/1
security.update_api_key	🟢	5/5	5/5
security.update_cross_cluster_api_key	🟠	Missing type	Missing type
security.update_settings	🟠	Missing type	Missing type
security.update_user_profile_data	🟢	1/1	1/1

You can validate these APIs yourself by using the make validate target.